Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): make table scrollable #598

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Conversation

Raincal
Copy link
Member

@Raincal Raincal commented Feb 3, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved N/A
Fix #597

What is the new behavior?

Description about this pull, in several words...

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang
Copy link
Contributor

Current behavior:
2019-02-04 1 23 06

New behavior:
2019-02-04 1 22 40

A table with insufficient width looks strange

@stevenjoezhang
Copy link
Contributor

It works great now!
2019-02-10 22-31-21 2019-02-10 22_32_32

And iissnan/hexo-theme-next#1582 has also been resolved

@Raincal Raincal merged commit babdd9e into theme-next:master Feb 10, 2019
@Raincal Raincal deleted the fix-table branch February 10, 2019 17:25
@Raincal Raincal added this to the v7.1.0 milestone Feb 10, 2019
@ivan-nginx ivan-nginx mentioned this pull request Feb 10, 2019
72 tasks
@ivan-nginx ivan-nginx added the v6.x label Mar 1, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
* fix(markdown): make table scrollable

* fix: wrap table with .table-container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird line breaking in table
3 participants