Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FCM cannot be unsubscribed #865

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Fix FCM cannot be unsubscribed #865

merged 2 commits into from
Mar 25, 2020

Conversation

robertu7
Copy link
Contributor

@robertu7 robertu7 commented Mar 24, 2020

Firebase may throw below error while we call messaging.deleteToken(token):

A problem occured while unsubscribing the user from FCM: FirebaseError: Messaging: A problem occured while unsubscribing the user from FCM: Requested entity was not found. (messaging/token-unsubscribe-failed). (messaging/token-unsubscribe-failed).

Before Firebase fixes this bug, we catch this error, then continue to unsubscribe from local and server.

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #865 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #865   +/-   ##
========================================
  Coverage    90.00%   90.00%           
========================================
  Files            1        1           
  Lines           10       10           
  Branches         2        2           
========================================
  Hits             9        9           
  Misses           1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2369f0a...1c1deca. Read the comment docs.

@robertu7
Copy link
Contributor Author

Copy link
Contributor

@guoliu guoliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌴

Copy link
Contributor

@devformatters devformatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go. 🍍

@robertu7 robertu7 merged commit 8de01fa into develop Mar 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/push branch March 25, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase.messaging.getToken() edgecase when push notification is set back to default (ask)
3 participants