Allow Zip64 files to have 0xffff as "number of this disk" in eocdr #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This should be fixed in yauzl version 3.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across a number of single-disk Zip64 files that have 0xffff as values for the "number of this disk" and the "number of the disk with the start of the central directory" in the standard eocdr, with the correct override values being present in the Zip64 eocdr.
This PR updates yauzl to handle these files, by only throwing if the standard disk count value is > 0 and < 0xffff, and adds an additional check on the zip64 disk count value.
Technically, this update would prevent yauzl from erroring on a multi-disk, non-zip64 file that actually has 0xffff parts / disks, but that would be one very contrived file.