-
Notifications
You must be signed in to change notification settings - Fork 344
Conversation
Hi @jgbradley1 , I think it could be interesting to submit this PR in the theia-apps repo? We already have misc Docker images there, as well as one Theia Electron application packaging example. |
This PR is in the theia-apps repo I believe...or did I mess something up? I'm just having a slight problem signing off on the work so the DCO check passes. Should be fixed soon. |
Confirmed - brainfart on my part I believe :) |
I gave this PR a try and it seems to work well. We could tweak the content of the packaged Theia app, but what's there already serves well for a RPM packaging example. I like the added doc too. Good job @jgbradley1 . It would be easy to add this app to CI and run the very light smoke test suite on the installed RPM package as well, but until we publish the .rpm, there may not be a strong need. The DCO is fixed now. Could you squash the commits? Then once we clarify the "spec" section in |
How would you like to handle the Solution 1: we keep it simple and hardcode Solution 2: Track the version number with an environment variable in the Docker image to make the necessary changes to |
I think an hardcoded version will do fine, for such an example, where the value lies more in the demonstration of how to nicely package a Theia app as a RPM vs making a Theia application for specific language(s)/purpose(s). |
I'll change the files so |
Commits are squashed. I have not previously squashed commits so let me know if something is off. |
@jgbradley1 Can you add a significant commit message, describing the content of this contribution? Does not need to be long or anything. I would mention the current limitation (IIUC) that the generated RPM would work on CentOS/RH Linux 7. Otherwise looking good! |
…ion. Tested and evaluated for CentOS/RH Linux 7. Older OS versions are not supported. For new version support, watch bbc/speculate#75 Signed-off-by: Joshua Bradley <jgbradley1@gmail.com>
Done. Let me know if you would like more info added to the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jgbradley1
A proof of concept demonstrating how to build a RPM of the cloud IDE.