/recordNodeMap endpoints for easier recording generation#3
Merged
Conversation
jbolda
changed the title
/recordNodeMap endpoints for easier recording generation
commit: |
cowboyd
reviewed
Feb 20, 2026
Comment on lines
+5
to
+19
| /** | ||
| * A function that transforms one stream into another | ||
| */ | ||
|
|
||
| export type Transform<A, B> = <TClose>( | ||
| input: Stream<A, TClose>, | ||
| ) => Stream<B, TClose>; | ||
|
|
||
| export interface Node { | ||
| id: string; | ||
| parentId?: string; | ||
| data: Record<string, unknown>; | ||
| } | ||
|
|
||
| export type NodeMap = Record<string, Node>; |
Member
There was a problem hiding this comment.
Is this the place for these types? They are very general.
Member
Author
There was a problem hiding this comment.
Yea, I don't love it either; open to suggestions.
I think after the deno migration, we should do a pass to organize all our files and write down where we expect things to go. Seems we have lots of possible implementations, so being explicit about it feels helpful.
Member
There was a problem hiding this comment.
After both me and Claude flailing at the deno migration, I'm thinking maybe ppm is just fine for now. It's hard to muster the strength to fix something that ain't really broke. :)
jbolda
force-pushed
the
record-node-map
branch
from
392e71e to
6077178
Compare
cowboyd
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds new endpoint which will return the
NodeMapinstead of the events.Requires this published before we can move forward here: thefrontside/effectionx#167
Approach
Still requires
curl, but at least it is in steps that can be followed in the readme.