refactor(durably): move scope middleware wiring into durably()#172
Open
taras wants to merge 1 commit intofeat/durablyfrom
Open
refactor(durably): move scope middleware wiring into durably()#172taras wants to merge 1 commit intofeat/durablyfrom
taras wants to merge 1 commit intofeat/durablyfrom
Conversation
Move scope middleware installation out of DurableReducer side effects and into durably(), so the entrypoint owns all scope wiring while DurableReducer continues to own lifecycle/replay logic. Also update halt-related tests to spawn durably operations with an explicit startup yield before halting, and skip the known finally-on-halt assertion until the upstream Effection bug is fixed.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
durably()already installs reducer middleware on its scope, but scope lifecycle middleware was installed indirectly insideDurableReducer.installScopeMiddleware(). This split middleware wiring across two modules and made the entrypoint/setup boundary less clear.The halt-related tests were also relying on immediate halt after spawn in a few places, which can halt a task before it reaches
suspend().Approach
DurableReducer.installScopeMiddleware()intocreateScopeMiddleware(runScope)that returns the same scope middleware handlers while keeping reducer lifecycle/replay logic encapsulated.durably()withscope.around(api.Scope, ..., { at: "max" }), sodurably()owns all scope wiring.suspend().package.jsonandpnpm-lock.yamlfrom the working tree state.