fix: add missing descriptions to deno-deploy and fetch packages#170
Merged
fix: add missing descriptions to deno-deploy and fetch packages#170
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo package.json files were updated to add description fields and to bump package versions: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deno-deploy/package.json`:
- Line 3: Remove the redundant "(deprecated)" text from the package.json
"description" field so the package description reads without the deprecation
note; rely on the existing "deprecated" field to convey deprecation to npm
consumers and keep the description concise (edit the "description" property in
package.json and leave the "deprecated" field unchanged).
Adds required description field to comply with Package.json Metadata policy: - deno-deploy: Detect Deno Deploy environment and access deployment metadata - fetch: Effection-native fetch with structured concurrency and streaming response support
091bb71 to
19a7f8f
Compare
cowboyd
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Two packages (
deno-deployandfetch) were missing the requireddescriptionfield in theirpackage.json, violating the Package.json Metadata Policy (Strict).The description field is required for:
Approach
Added compliant description fields to both packages following the policy guidelines:
Changes:
@effectionx/deno-deploy@effectionx/fetchBoth packages received a patch version bump per the Version Bump policy.
Verification:
pnpm build✓pnpm check✓pnpm lint✓Summary by CodeRabbit