chore: test preview effection with createApi support#163
Conversation
Add pnpm override to use effection from PR thefrontside/effection#1116. This PR is to observe which tests fail/hang with preview effection.
📝 WalkthroughWalkthroughThe PR updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
19-36:⚠️ Potential issue | 🟠 MajorAdd a semantic version bump for this package.json change.
Policy requires a version bump when package.json changes; this file has no
versionfield. Please add and bump the version appropriately (or document an explicit exemption for the private root package).
As per coding guidelines, “If package.json changes, include a semantic version bump.”🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 19 - 36, The package.json change requires a semantic version bump: add or update the "version" field in package.json (e.g., increment patch from the current release to a new semver like "1.0.1") so the commit includes a clear version change; alternatively, if this is an intentional private root package, add an explicit "private": true entry and document that exemption in the PR description. Ensure you update the "version" key consistently and mention the reason (bumped for package.json changes) in the commit message.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@package.json`:
- Around line 19-36: The package.json change requires a semantic version bump:
add or update the "version" field in package.json (e.g., increment patch from
the current release to a new semver like "1.0.1") so the commit includes a clear
version change; alternatively, if this is an intentional private root package,
add an explicit "private": true entry and document that exemption in the PR
description. Ensure you update the "version" key consistently and mention the
reason (bumped for package.json changes) in the commit message.
Summary
Context
The
createApifeature needed for middleware support in fetch/process/fspackages is only available in preview effection. This PR tests the impact
of using preview effection across the monorepo.
Expected Failures
Based on local testing, these tests are expected to fail due to scope
teardown timing changes:
effect-ts: 2 testsstream-helpers: 1 valve testRelated PRs
Summary by CodeRabbit