Open
Conversation
Add dark:hover:bg-gray-800 to menu links for proper contrast in dark mode.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In dark mode, the API side menu links have poor contrast on hover. The
hover:bg-gray-100class creates a very light gray background that clashes with the dark theme.Approach
Add
dark:hover:bg-gray-800to the menu link hover state, matching the pattern already used in the guides sidebar.Before:
hover:bg-gray-100(light gray hover in both modes - poor contrast in dark mode)After:
hover:bg-gray-100 dark:hover:bg-gray-800(appropriate contrast in both modes)Visual Change
The fix ensures hover states in the sidebar navigation are clearly visible in dark mode, improving accessibility and user experience.