-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document task launching in detail #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezr-ondrej
force-pushed
the
launch_docs
branch
from
November 15, 2021 22:21
944b15d
to
881ef96
Compare
ezr-ondrej
force-pushed
the
launch_docs
branch
from
November 16, 2021 16:12
881ef96
to
b3f7d20
Compare
adamruzicka
reviewed
Nov 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some typos, but in general it is in line with what I remember about it
adamruzicka
reviewed
Nov 29, 2021
ezr-ondrej
force-pushed
the
launch_docs
branch
from
November 29, 2021 10:51
bab8448
to
9796250
Compare
adamruzicka
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @ezr-ondrej ! |
ekohl
added a commit
to ekohl/smart_proxy_dynflow
that referenced
this pull request
Aug 1, 2023
Fixes: b0753fd ("Document task launching in detail (theforeman#99)")
ekohl
added a commit
to ekohl/smart_proxy_dynflow
that referenced
this pull request
Aug 1, 2023
Fixes: b0753fd ("Document task launching in detail (theforeman#99)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to go more in depth on task launching