Skip to content

fix #973: fix order chaining in agent.pp #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flo2388 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix #973: fix order chaining in agent.pp #976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/agent.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
contain puppet::agent::config
contain puppet::agent::service

Class['puppet::agent::install'] ~> Class['puppet::agent::config', 'puppet::agent::service']
Class['puppet::agent::install'] ~> Class['puppet::agent::config'] ~> Class['puppet::agent::service']
Class['puppet::config', 'puppet::agent::config'] ~> Class['puppet::agent::service']
Comment on lines +8 to 9
Copy link
Member

@evgeni evgeni Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already is a Class['puppet::agent::config'] ~> Class['puppet::agent::service'] on the next line, so this seems unnecessary?

Copy link
Member

@evgeni evgeni Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not saying there is no bug somewhere, just that this change should be a noop)

Copy link
Member

@ekohl ekohl Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means that an update to the agent package no longer restarts the agent service because there's no transitive property between chaining. If Class['puppet::agent::config'] is notified, it only notifies the contained resources. It will only notify others if one of those contained resources makes a change.

Concrete: if you change the package version, but not the config then there won't be a service restart.

Now your package manager may restart the service already. I can imagine there's some race condition between those 2.

}
Loading