Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing dep on puppet/mosquitto #752

Merged
merged 1 commit into from
May 4, 2022
Merged

add missing dep on puppet/mosquitto #752

merged 1 commit into from
May 4, 2022

Conversation

jhoblitt
Copy link
Contributor

@jhoblitt jhoblitt commented May 3, 2022

Resolves #751

@jhoblitt
Copy link
Contributor Author

jhoblitt commented May 3, 2022

/CC @ehelms @evgeni

evgeni
evgeni reviewed May 3, 2022
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good find! We wanted to keep that optional, but with the cleanup that Eric implemented it's not optional anymore.

metadata.json Outdated Show resolved Hide resolved
@jhoblitt jhoblitt force-pushed the bugfix/mosquitto-dep branch from b43246c to 32ac181 Compare May 3, 2022 20:17
@evgeni evgeni added the Bug label May 3, 2022
@jhoblitt
Copy link
Contributor Author

jhoblitt commented May 3, 2022

It may be a good idea to change the beaker setup to configure_beaker(modules: :metadata) so metadata errors will be caught in the future.

@evgeni evgeni merged commit 58fa4c7 into theforeman:master May 4, 2022
@jhoblitt jhoblitt deleted the bugfix/mosquitto-dep branch July 8, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
Bug Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

22.1.0 release is missing dep on puppet/mosquitto
3 participants
@jhoblitt @evgeni @theforeman-bot