Lazily load tftp directories #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It now fails since it's used in templates: Before I start diving into this, I'd like to know if people agree this is a good path forward. |
|
This makes sense to me to only perform necessary actions, set necessary variables if a feature is enabled. I would proceed ahead with diving in. |
This change makes tftp directories lazy. It does that by making the parameters undef by default and determine them if tftp is actually included. The main motivation is that f849d12 changed the tftp module. Prior to it, the logic was duplicated. With that change, it became dynamic which also made it a hard dependency. Technically it already was since it's always been listed in metadata.json. However, it functioned without it if tftp was false. With this change it really becomes optional.
This command requires the directory to exist. This has always been needed, but previously it mostly happened to install in the right order so it was missed.
|
This is now ready for review. The one test that's failing is expected since there's no Puppet 5 AIO package on Ubuntu 20.04. |
ehelms
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes tftp directories lazy. It does that by making the parameters undef by default and determine them if tftp is actually included.
The main motivation is that f849d12 changed the tftp module. Prior to it, the logic was duplicated. With that change, it became dynamic which also made it a hard dependency. Technically it already was since it's always been listed in metadata.json. However, it functioned without it if tftp was false. With this change it really becomes optional.
Alternative to #673.