Fixes #32235,#19494 - Run Dynflow within smart-proxy on EL*

[adamruzicka]

Implements step 2 of Phasing out smart_proxy_dynflow_core

[ehelms]

You could pull https://github.com/theforeman/puppet-foreman_proxy/pull/655/files/7103a1a6e7aad3559198a760479f7a7a1a7f9419..b6c140d71a7e4b467d6adf82469c8da528b5632f#diff-30599268ecf267469b31876ad92802766e3596423d310db9aa425b7db9cc2beeR79 out of the if-else and set the properties on it based on external_core.

    service { 'smart_proxy_dynflow_core':
      ensure => $external_core,
      enable => $external_core,
    }

[adamruzicka]

Is it worth it? I mean the entire true branch will get dropped once we get to stage 3 of the proposal

[ehelms]

Is it worth it? I mean the entire true branch will get dropped once we get to stage 3 of the proposal

Will that happen this Foreman release or afterwards? (stage 3)

[adamruzicka]

Most likely in the next one

[ehelms]

Should I see the dynflow plugin present and working inside the smart-proxy on a Katello install?

[adamruzicka]

If it was a fresh install then yes. If an upgrade (or if installer was run before applying patches from this PR) then no. We'll most likely need an installer migration

[ehelms]

If it was a fresh install then yes

I think we are missing this in the answers file, so likely need updates all around after I grepped through -- https://github.com/theforeman/foreman-installer/blob/develop/config/katello-answers.yaml

[ekohl]

Overall this looks good.

[ekohl]

Also, can we open an issue in the installer Redmine project?

[ekohl]

This looks good to me. I edited the PR title to what I think is a bit better description of what it's achieving. Do you want to squash the commits, should I or is it intention that it's multiple commits?

[adamruzicka]

Squashed the commits into two, one for running dynflow within smart proxy, the other for setting open file limits for smart proxy.

[ekohl]

Should I move https://projects.theforeman.org/issues/19494 to the Installer project?

[ekohl]

Thanks! Merging this and we'll see how it goes in nightly.

[ekohl]

Since @ehelms also reviewed, I'll give him a chance for a last look over.