Fixes #30072 - update grub default template #598
Conversation
|
TBH I'm surprised we include this template in the puppet module at all, why is this needed? |
files/grub.cfg
Outdated
| echo "to create the default global grub.cfg configuration." | ||
| echo "This system will poweroff shortly." | ||
| sleep 900 | ||
| poweroff |
There was a problem hiding this comment.
Looks like a very extreme response to me, especially given the fact that this can concern remote h/w hosts.
There was a problem hiding this comment.
Suggest something better that prevents confused users when this template does not work. Problem is that by default we try to chainload EFI from ESP here and this has been broken multiple times already. I change it way too often and forget it's here.
There was a problem hiding this comment.
What's happening without the poweroff?
There was a problem hiding this comment.
That depends on the firmware I guess, but for libvirt it's grub shell. I can remove that poweroff if you want, I just wanted to prevent endless loops.
|
@tbrisker it surprised me three times already. My long-term memory is as bad as my short-term memory. On the other hand, I often enjoy my favourite films over and over again :-) |
|
@lzap what is the status shere? can you rebase please? will the removal of poweroff make this mergeable? |
lzap
force-pushed
the
definitive-default-grub-30072
branch
from
f4185e0 to
77dc519
Compare
|
Rebased, removed the poweroff command. |
lzap
force-pushed
the
definitive-default-grub-30072
branch
from
77dc519 to
c59191b
Compare
|
Fixed the test. |
|
Tests are green. |
lzap
force-pushed
the
definitive-default-grub-30072
branch
from
c59191b to
315b389
Compare
This happened now the third time and it took us to figure it out. Our installer deploys a copy of "PXEGrub2 global default" template which is susppoed to be overwirten after Build PXE default is clicked. However we never keep it up to date and we are getting feedback that "sometimes" the default template does not work well as we change it over the releases.
This is the definitive solution to this - users are asked to click on the button before they attempt to boot unknown hosts. This solves the issue (the template does not work for UEFI HTTP booted hosts) and prevents from this in the future.