Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extlib 5.x #578

Merged
merged 1 commit into from
May 4, 2020
Merged

Allow extlib 5.x #578

merged 1 commit into from
May 4, 2020

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Apr 1, 2020

No description provided.

@mmoll mmoll closed this Apr 1, 2020
@mmoll mmoll reopened this Apr 1, 2020
@ekohl
Copy link
Member

ekohl commented Apr 2, 2020

Looks like we'll need a released version for acceptance tests to pass :(

@mmoll
Copy link
Contributor Author

mmoll commented Apr 2, 2020

I'd say this can stay open and just wait a bit...

ekohl
ekohl approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restarted one acceptance test and it passed. Trusting the rest will pass too.

@ekohl ekohl merged commit 4d2b840 into theforeman:master May 4, 2020
@mmoll mmoll deleted the extlib5 branch May 4, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmoll @ekohl @theforeman-bot @wbclark