Fixes #28559 - keep default ssh args #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://docs.ansible.com/ansible/latest/reference_appendices/config.html#ansible-ssh-args the ssh args is by default se to "-C -o ControlMaster=auto -o ControlPersist=60s". In #25481, this was overriden to "-o ProxyCommand=none" only. There seems to be no way to just append areguments, so listing defaults here is probably the best option.
ekohl
approved these changes
Dec 25, 2019
|
Thanks! |
|
This is great, but Shouldn't we have migration for this? |
|
Trying to do so here: theforeman/foreman-installer#635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://docs.ansible.com/ansible/latest/reference_appendices/config.html#ansible-ssh-args
the ssh args is by default se to "-C -o ControlMaster=auto -o ControlPersist=60s". In #25481, this
was overriden to "-o ProxyCommand=none" only. There seems to be no way to just append areguments,
so listing defaults here is probably the best option.