Fix tests by using a better IPv6 check #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Almost there :) |
rspec-puppet 2.7.8 has started to always set an ipaddress6 fact and deleting no longer works. Setting it to nil does work. The fact() function returns a fact or undef if it can't be found which means it's still a valid way to check if IPv6 is present.
The latest version has ArchLinux facts with legacy facts. This also brings in facts for Red Hat 7.5+ so the tests need to be modified for that.
|
New attempt. Let's see if it does work now. |
|
💚 finally! |
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7dff714 More robust check for IPv6
rspec-puppet 2.7.8 has started to always set an ipaddress6 fact and deleting no longer works. Setting it to nil does work. The fact() function returns a fact or undef if it can't be found which means it's still a valid way to check if IPv6 is present.
0c5514c Unpin facterdb
The latest version has ArchLinux facts with legacy facts.