Refactor plugin parameter handling #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
changed the title
|
@ekohl tests fail |
ekohl
force-pushed
the
infoblox-dns
branch
3 times, most recently
from
9db590a to
d40c691
Compare
|
@ekohl needs a rebase ;) |
|
Rebased. Also includes some spec improvements as separate commits to speed up the testing. |
|
Fails on Puppet 5 💔 |
Passing in a supported_os array instead of filtering the result is much faster because it doesn't have to load the entire database.
This mechanism is custom and not used. rspec-puppet-facts has SPEC_FACTS_OS to filter which has the added benefit that it filters natively and is faster. It's not removed from spec_helper.rb because that's rsynced.
When all values are static, there's no need to load it via a params class. It also tightens some parameter types.
|
Looks like this reduces the unit test time from 21 to 26 minutes (https://travis-ci.org/theforeman/puppet-foreman_proxy/builds/629474276) to 6 to 7 minutes (https://travis-ci.org/theforeman/puppet-foreman_proxy/builds/629687391). |
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all values are static, there's no need to load it via a params class. It also tightens some parameter types.