Disable repository management by default #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need an installer migration as well. |
ehelms
approved these changes
Dec 17, 2018
Because we're trying to move people away from the latest repository, we set it to configure an explicit version with a default. Because this default would need to be updated all the time, it's a bad idea. This patch removes the $custom_repo and makes $repo undef by default. This means users get no repository by default and need to explicitly choose which repository to use. Because repo management would not be of much interest to installer users, we move it together with $gpgcheck to the advanced section.
ekohl
force-pushed
the
repo-management
branch
from
7ef69ec to
b526c91
Compare
|
💚 now |
mmoll
approved these changes
Dec 17, 2018
|
@ekohl the installer migration is missing currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we're trying to move people away from the latest repository, we
set it to configure an explicit version with a default. Because this
default would need to be updated all the time, it's a bad idea.
This patch removes the $custom_repo and makes $repo undef by default.
This means users get no repository by default and need to explicitly
choose which repository to use.
Because repo management would not be of much interest to installer
users, we move it together with $gpgcheck to the advanced section.