attempt a more accurate DNS/DHCP default interface #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Feb 28, 2018
manifests/params.pp
Outdated
| @@ -283,7 +283,7 @@ | |||
| $dhcp_managed = true | |||
| $dhcp_provider = 'isc' | |||
| $dhcp_subnets = [] | |||
| $dhcp_interface = 'eth0' | |||
| $dhcp_interface = pick($facts['networking']['primary'], 'eth0') | |||
There was a problem hiding this comment.
On Puppet 4 with Debian AIO you don't have networking facts so this may be an issue (Error: Evaluation Error: Operator '[]' is not applicable to an Undef Value.). Since we're on stdlib 4.19.0 we can rely on fact('networking.primary') instead which returns undef but doesn't raise an error on undefined index thus solving the problem.
sean797
force-pushed
the
default-interface
branch
from
4a7293c to
c6c43af
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Nice, thanks. Updated 👍 |
ekohl
approved these changes
Feb 28, 2018
|
This just missed a8d37b6 even though I didn't upload yet. Will see what I do tomorrow. |
|
merged, thanks @sean797! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.