Only install directories if tftp is managed

[mattj-io]

Only install the directories and pxe files if tftp_managed is true.

[mmoll]

This is a bit against what I wanted with introducing the parameter, however seeing this now, I think it would probably be better to move some things from here into our tftp module, but would like to hear other maintainer's voices.

The background back then was that I want to use foreman-installer to install everything needed to have a libvirt compute resource with DNS/DHCP enabled and libvirt used as TFTP server (so the regular TFTP daemon should not get installed), as that's a common small setup. When testing this on a fresh, clean system last week, however, I already ran into the problem that syslinux wasn't installed and one (or more?) needed directories were not created.

[domcleal]

I think the idea of the change is fine, but it should probably move to foreman_proxy::config in the same way that dhcp_managed works.

[mmoll]

@dc-mattj what's the status here?

[mattj-io]

Sorry, lost track of this one slightly. Will take a look tomorrow at the foreman_proxy::config stuff and refactor the change.

[mmoll]

lint fails with:

manifests/tftp.pp:18:WARNING: top-scope variable being used without an explicit namespace
manifests/tftp.pp:3:ERROR: trailing whitespace found

[mattj-io]

Sorry, my bad - fixed now

[mmoll]

superfluous newline

[mmoll]

please update (or best extend) the tests, I cancelled all except the 2.3.0 run of this commit to save resources

[mattj-io]

Tests updated

[domcleal]

Thanks @dc-mattj!

[ekohl]

I wonder if we should provide a tftp_provider. This could allow using libvirt but initially a noop provider that just places the files could help theforeman/forklift#295

[mmoll]

As for the proxy side there's nothing really changing, maybe we should have a "libvirt" and a "tftpd" backend in puppet-tftp?

[stbenjam]

I don't really know if a libvirt provider is useful to anyone in puppet-tftp, as the only useful thing being done for libvirt is creation and population of the directories and such which is done here.

[mmoll]

the steps of editing the libvirtd XML could be automated so tftp gets enabled