Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hammer plugin for foreman_puppet #979

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Add hammer plugin for foreman_puppet #979

merged 1 commit into from
Aug 3, 2021

Conversation

amirfefer
Copy link
Member

No description provided.

@amirfefer amirfefer force-pushed the add-hcf-puppet branch 2 times, most recently from b55e9ad to 729cf9d Compare August 3, 2021 12:41
ekohl
ekohl reviewed Aug 3, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but I expect the acceptance test to fail. The packages have not yet been published. Somehow they appear to stop after 3 seconds. I have a theory why they fail.

@ekohl
Copy link
Member

ekohl commented Aug 3, 2021

#980 should fix that.

ekohl
ekohl approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll fix the Debian packages later.

@ekohl ekohl merged commit 9b2fcc6 into theforeman:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amirfefer @ekohl @theforeman-bot