fixes #29938 - change default logging layout #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want to make this active for all existing installations, it also needs an installer migration. |
|
Core has been merged, @domitea please add the migration as suggested |
domitea
force-pushed
the
29938_new_logging_layout
branch
from
eefb4d1 to
a3b17c3
Compare
|
Migration added in theforeman/foreman-installer#557, also Readme.md was affected by this change. |
ekohl
requested changes
Aug 5, 2020
README.md
Outdated
| @@ -74,7 +74,7 @@ previous stable release. | |||
|
|
|||
| ### Foreman version compatibility notes | |||
|
|
|||
| This module targets Foreman 2.0+. | |||
| This module targets Foreman 2.2+. | |||
There was a problem hiding this comment.
We don't do this, see the support policy. Instead, we would write a new paragraph that on Foreman versions older than 2.2 you need to change the logging layout parameter to pattern.
|
And you need to add the new value to the valid values in |
Merged
domitea
force-pushed
the
29938_new_logging_layout
branch
from
a3b17c3 to
ad56f99
Compare
|
@ekohl thanks for mentioning enum! Readme updated. |
|
@ekohl what's the status here? |
ekohl
approved these changes
Oct 21, 2020
|
It sort of slipped form my radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary PR for theforeman/foreman#7220 to make default new kind of logger mentioned in liked PR