Use legacy facts for puppetmaster defaults #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
875c837 started to use modern facts. However, for these branches there is no coverage and facterdb can't find these modern facts. This causes issues in puppet-puppet which does call these branches. Ignoring lint is the quickest fix now. Longer term these classes will be split out to its own module as theforeman/puppetserver_foreman so there can be test coverage.
ehelms
approved these changes
Apr 29, 2020
|
Turns out this was incorrect. Sadly there is no coverage for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
875c837 started to use modern facts. However, for these branches there is no coverage and facterdb can't find these modern facts. This causes issues in puppet-puppet which does call these branches. Ignoring lint is the quickest fix now.
Longer term these classes will be split out to its own module as theforeman/puppetserver_foreman so there can be test coverage.