Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #35675 - Add hammer-cli-foreman-google plugin #1090

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Refs #35675 - Add hammer-cli-foreman-google plugin #1090

merged 1 commit into from
Nov 1, 2022

Conversation

ofedoren
Copy link
Member

@stejskalleos for visibility.

@ofedoren ofedoren mentioned this pull request Oct 25, 2022
Closed
4 tasks
@ekohl
Copy link
Member

ekohl commented Oct 26, 2022

Lint is failing, but #1092 should resolve that.

@ofedoren ofedoren force-pushed the refs-35675-add-hammer-cli-foreman-google branch from f1bbadd to bc37ce0 Compare October 30, 2022 14:46
@ofedoren
Copy link
Member Author

Thanks, rebased.

ekohl
ekohl approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Test failure is unrelated.

@ekohl ekohl merged commit 2ea2537 into theforeman:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofedoren @ekohl @theforeman-bot