allow overriding of deploy params by a vendor - #643
Draft
evgeni wants to merge 1 commit into
Draft
Conversation
evgeni
commented
Jul 10, 2026
evgeni
commented
Jul 10, 2026
| flavor: | ||
| help: Base flavor to use in this deployment. | ||
| choices: | ||
| - satellite |
Member
Author
There was a problem hiding this comment.
Obviously, this file should not be shipped like this in foremanctl, but be provided by a vendor-branding-package
evgeni
force-pushed
the
vendor-override
branch
2 times, most recently
from
July 31, 2026 10:48
2b38df4 to
271a777
Compare
Member
|
I was thinking this should get merged (the parts that make sense to) and then CI for #726 should create the vendor file. This would then reflect the model we expect and test this override method? |
evgeni
force-pushed
the
vendor-override
branch
from
August 11, 2026 08:54
271a777 to
b2a3ee9
Compare
Member
Author
|
updated based on latest learnings and experiments from #726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
Vendors might want to override our CLI definition
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
Checklist