Fixes #38768: get rid of grub (not grub2)

[sbernhard]

No description provided.

[sbernhard]

May have a look @stejskalleos

[stejskalleos]

Found a few places mentioning old Grub, but otherwise great cleanup!

• https://github.com/theforeman/foreman/blob/develop/app/services/foreman/renderer/scope/macros/base.rb#L92
• webpack/assets/javascripts/foreman_hosts.test.js
• webpack/assets/javascripts/foreman_hosts.js

I went over other repositories to check the status there:

• foreman-packaging ✔️
• hammer-cli ✔️
• foreman_bootdisk ✔️
• foreman_discovery - ⚠️
• foreman_theme_satellite - ⚠️
• installer theforeman/foreman-installer#1040
• smart_proxy #10698

I will take care of the cleanup for the repositories

[sbernhard]

Interesting what tests I broke with the last push? Are they related or did something else change?

[stejskalleos]

It looks like you indeed broke the tests, on my local develop tests work fine, but not on your branch.

But it's really weird, why are duplicate_json_keys failing now? I'm looking into it.

[stejskalleos]

Nope, I take back my previous comment. RAILS_ENV=test bundle exec rake test:units is generating the same warning flood as Github CI.

[sbernhard]

Nope, I take back my previous comment. RAILS_ENV=test bundle exec rake test:units is generating the same warning flood as Github CI.

I think, wvanbergen/scoped_search@b9a64fc broke this: https://github.com/theforeman/foreman/actions/runs/18006520466/job/51228060554?pr=10698#step:16:28

And this looks like also related to the broken unit test: https://github.com/theforeman/foreman/actions/runs/18011179034/job/51244143760#step:16:149

@adamruzicka is working on it in: #10677

[stejskalleos]

I'm still able to reproduce the issue without the PR you mentioned.

ruby 3.0.7p220 (2024-04-23 revision 724a071175) [x86_64-linux]

playground.rb

require 'facterdb'
filter = "operatingsystemmajrelease=10"
result = FacterDB.get_facts(filter)

Running bundle exec ruby playground.rb works fine.

Then in the /path/to/gems/jgrep-1.5.4/lib/jgrep.rb:27 file, I change:

json = JSON.parse(json)
# TO:
json = JSON.parse(json, {allow_duplicate_key: false})

Running bundle exec ruby playground.rb:

Error. Invalid JSON given
/home/lstejska/.rbenv/versions/3.0.7/lib/ruby/gems/3.0.0/gems/facterdb-1.27.0/lib/facterdb.rb:146:in `get_facts': undefined method `map' for nil:NilClass (NoMethodError)
	from playground.rb:4:in `<main>'` 

So, when we upgrade Rails and its json gem, this will happen anyway.

Suspect: https://github.com/voxpupuli/facterdb/blob/1.27.0/lib/facterdb.rb#L146

[sbernhard]

@stejskalleos Regarding the warnings, they happen in other PRs, too:

https://github.com/theforeman/foreman/actions/runs/18109383564/job/51531963389?pr=10707#step:16:674

[stejskalleos]

🍏 LGTM

[stejskalleos]

thanks @sbernhard