Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add elastic apm plugins #3625

Merged
merged 2 commits into from
Aug 29, 2019
Merged

add elastic apm plugins #3625

merged 2 commits into from
Aug 29, 2019

Conversation

timogoebel
Copy link
Member

@timogoebel timogoebel commented Apr 12, 2019 •
edited
Loading

This adds foreman_supervisory_authority and smart_proxy_elasticapm.

The elastic apm agent requires at last ruby 2.3.0, so we won't be able to run it on smart-proxy. :-(

@timogoebel timogoebel force-pushed the elastic-apm branch 2 times, most recently from 0ad7696 to cb2e4af Compare April 12, 2019 12:56
@timogoebel
Copy link
Member Author

[test rpm]

@timogoebel timogoebel force-pushed the elastic-apm branch 2 times, most recently from 6e674e4 to 28b1fe0 Compare April 12, 2019 13:24
ekohl
ekohl requested changes May 13, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase now.

packages/plugins/rubygem-elastic-apm/rubygem-elastic-apm.spec Outdated Show resolved Hide resolved
packages/plugins/rubygem-elastic-apm/rubygem-elastic-apm.spec Outdated Show resolved Hide resolved
packages/plugins/rubygem-elastic-apm/rubygem-elastic-apm.spec Outdated Show resolved Hide resolved
packages/plugins/rubygem-http/rubygem-http.spec Outdated Show resolved Hide resolved
packages/plugins/rubygem-http/rubygem-http.spec Outdated Show resolved Hide resolved
packages/plugins/rubygem-http/rubygem-http.spec Outdated Show resolved Hide resolved
packages/plugins/rubygem-http_parser.rb/rubygem-http_parser.rb.spec Outdated Show resolved Hide resolved
@timogoebel timogoebel changed the title [WIP] add elastic apm plugins add elastic apm plugins Jul 19, 2019
@timogoebel
Copy link
Member Author

@ekohl: I've released the plugin and added packaging here. Mind taking a look?

@ekohl
Copy link
Member

ekohl commented Jul 19, 2019

[test rpm]

1 similar comment
@timogoebel
Copy link
Member Author

[test rpm]

@evgeni
Copy link
Member

evgeni commented Jul 23, 2019 

BUILDSTDERR: error: Installed (but unpackaged) file(s) found:
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/.jenkins_exclude.yml
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/.jenkins_framework.yml
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/.jenkins_ruby.yml
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/Jenkinsfile
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/bin/check_paths_for_matches.py
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/downstreamTests.groovy
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/jobs/apm-agent-ruby-downstream.yml
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/jobs/apm-agent-ruby-mbp.yml
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/jobs/apm-agent-ruby.yml
BUILDSTDERR:    /opt/theforeman/tfm/root/usr/share/gems/gems/elastic-apm-2.9.1/.ci/jobs/defaults.yml

I think you need some more %excludes

@timogoebel
Copy link
Member Author

I think you need some more %excludes

Re-generated the spec file.

@timogoebel
Copy link
Member Author

@ekohl: Anything missing here?

@laugmanuel laugmanuel mentioned this pull request Aug 28, 2019
Merged
ekohl
ekohl approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was off my radar but looks to be green.

@ekohl ekohl merged commit 1e7a8d4 into theforeman:rpm/develop Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni left review comments

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Needs testing RPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timogoebel @ekohl @evgeni @theforeman-bot