Repository navigation
feat(vendor-core): adding react-markdown - #140
Merged
Merged
Conversation
sharvit
suggested changes
Jun 10, 2020
sharvit
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your contributions @patilsuraj767 👍
-
Please run
npm installin the foreman-js root folder to update the lock file -
Update the vendor-core/lib/modules.js file so the
react-markdownlib would be available for foreman and plugins. -
If you would like to test it locally, see: http://theforeman.github.io/foreman/?path=/docs/introduction-adding-dependencies--page
-
Bonus: If you can improve the docs based on your experience (in a different PR), we would very appreciate that :)
sharvit
approved these changes
Jun 10, 2020
sharvit
left a comment
Contributor
There was a problem hiding this comment.
Thanks @patilsuraj767, LGTM 👍
Contributor
|
🎉 This PR is included in version The release is available on:
Thank you for your contribution, your foreman-js bot 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Packages
PR Type
Description
Does this PR introduce a breaking change?
Does this PR fixes open issues?
Foreman core issue - https://projects.theforeman.org/issues/30034
Do you use this PR in another repository?
theforeman/foreman#7725