Skip to content

feat(vendor-core): adding react-markdown - #140

Merged
sharvit merged 2 commits into
theforeman:masterfrom
patilsuraj767:add-react-markdown
Jun 10, 2020
Merged

sharvit merged 2 commits into
theforeman:masterfrom
patilsuraj767:add-react-markdown

Conversation

@patilsuraj767

Copy link
Copy Markdown
Contributor

Updated Packages

  • root
  • @theforeman/builder
  • @theforeman/test
  • @theforeman/eslint-plugin-foreman
  • @theforeman/stories
  • @theforeman/vendor
  • @theforeman/vendor-dev
  • @theforeman/vendor-core

PR Type

  • Bugfix
  • Feature
  • Code style update (whitespace, formatting, missing semicolons, etc.)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other… Please describe:

Description

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR fixes open issues?

  • Yes
  • No

Foreman core issue - https://projects.theforeman.org/issues/30034

Do you use this PR in another repository?

  • Yes
  • No

theforeman/foreman#7725

@sharvit sharvit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions @patilsuraj767 👍

  1. Please run npm install in the foreman-js root folder to update the lock file

  2. Update the vendor-core/lib/modules.js file so the react-markdown lib would be available for foreman and plugins.

  3. If you would like to test it locally, see: http://theforeman.github.io/foreman/?path=/docs/introduction-adding-dependencies--page

  4. Bonus: If you can improve the docs based on your experience (in a different PR), we would very appreciate that :)

@sharvit sharvit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patilsuraj767, LGTM 👍

@sharvit
sharvit merged commit b27dcd9 into theforeman:master Jun 10, 2020
@sharvit

sharvit commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Thank you for your contribution, your foreman-js bot 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants