Refs #32175: Set foreman-tasks backup to true on upgrades #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For new installations, the intent is to default to task cleanup to not store backups of the tasks deleted. Since the previous behavior is to store backups on cleanup, when upgrading users should retain the same behavior and intentionally disable backups to prevent unexpected behavior changes.
|
Results from theforeman/puppet-foreman#922 |
ekohl
approved these changes
Mar 23, 2021
|
theforeman/puppet-foreman#922 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For new installations, the intent is to default to task cleanup
to not store backups of the tasks deleted. Since the previous
behavior is to store backups on cleanup, when upgrading users
should retain the same behavior and intentionally disable backups
to prevent unexpected behavior changes.