A11y/main #16
Merged
A11y/main #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocus on it when the component mounts (useEffect) and then assign a tabIndex depending on whether or not the component has mounted or not
…ler did not fire when FocusTrap was on ItemCustomizationPanel.
…CSStransitiongroup to render dynamically since FocusTrap component relies on rendering lifecycles to trap. Or, set focustrap props before animations
Font optimization/a11y/main
…ages now decode in async for the first 3 images in the carousel
…hat are required to animate. enter width of the containing element in px
…ow use FocusTrap to wrap the elements in focus, although they will need a semantic group name now
…ad of using isOpenFromCartSheet, since props.state is the timely value
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<CartSheet />and<ItemOverlay />, using the Focus Trap React library. 8a026fa ea36f8b ab3aa38 f57e1d5aria-labeladded to major UI elements.aria-live="polite"added to state change items, like cart item counters. These values re-announce themselves to provide meaningful feedback 57ca18d 5da637b f5c1b9d a13374b 435bb22<Shimmer />component for images. This component receives awidth: numberprop that helps decide the width of the animation range. Best to use 2x the width of element being shimmered as this number (in pixels) b8d61e4 1b54344 6c39960 511f1ad 04be795