Make FullVersion a superset of Version #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
requested changes
Dec 12, 2023
Shouldn't the FullVersion include all fields from Version?
sirhcel
force-pushed
the
full-version-superset-of-version
branch
from
fbdf35a
to
aec2197
Compare
theduke
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this awesome crate! While working on some MSRV checks on top of it, I was in the need of having
rust_versionalso available inFullVersion. At the end I went a bit further and this PRrust_versiontoFullVersionVersionintoFullVersionas the naming suggests the latter being a superset of the former to meVersiontoFullVersioninto a shared implementation ofFromfor not needing to keep the details in sync in both clients manuallyrustdoc