Open
Conversation
NodeId, LinkId and PinId are just glorified pointers. In some cases
32/64 bits of data may not be enough to identify an object, or the
objects may lack a stable pointer/id value.
This commit adds a way to specify custom data types for them:
similarly to ImGui, a IMGUI_NODE_EDITOR_USER_CONFIG macro can be set
before including imgui_node_editor.h. If defined, its value will be
used as a filename to be included at the top of imgui_node_editor.h.
In it, the macros IMGUI_NODE_EDITOR_CUSTOM_NODEID,
IMGUI_NODE_EDITOR_CUSTOM_PINID and IMGUI_NODE_EDITOR_CUSTOM_LINKID
may be defined as the names of the types to be used for them.
If one or more of them are not defined the old types will be used,
old code does not need to be changed.
The types used must be copy contructible, assignable and must provide
a few more functions, as in this example:
struct CustomId
{
CustomId(const CustomId &id);
CustomId &operator=(const CustomId &id);;
bool operator<(const CustomId &id) const;
bool operator==(const CustomId &id) const;;
std::string AsString() const;
static CustomId FromString(std::string_view str);
bool IsValid() const;
static const CustomId Invalid;
};
A new example showcasing the functionality is added.
|
I think providing some methods to convert graph data into IDs, or even restore graph data through IDs will make the project more convenient. Can you consider this further? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeId, LinkId and PinId are just glorified pointers. In some cases
32/64 bits of data may not be enough to identify an object, or the
objects may lack a stable pointer/id value.
This commit adds a way to specify custom data types for them:
similarly to ImGui, a IMGUI_NODE_EDITOR_USER_CONFIG macro can be set
before including imgui_node_editor.h. If defined, its value will be
used as a filename to be included at the top of imgui_node_editor.h.
In it, the macros IMGUI_NODE_EDITOR_CUSTOM_NODEID,
IMGUI_NODE_EDITOR_CUSTOM_PINID and IMGUI_NODE_EDITOR_CUSTOM_LINKID
may be defined as the names of the types to be used for them.
If one or more of them are not defined the old types will be used,
old code does not need to be changed.
The types used must be copy contructible, assignable and must provide
a few more functions, as in this example:
struct CustomId
{
CustomId(const CustomId &id);
CustomId &operator=(const CustomId &id);;
};
A new example showcasing the functionality is added.