Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package has no way to clear errors #80

Closed
middelink opened this issue Mar 27, 2020 · 0 comments
Closed

Package has no way to clear errors #80

middelink opened this issue Mar 27, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@middelink
Copy link

Greetings,

When using the package to fetch various fields (user supplied paths) in sequence, I noticed that after the first error, ALL Find()'s fail with the same error. Looking through the code, it seems j.errors gets appended, but never reset.

Should it not be part of Reset()? Or if that is not appropriate, have it as a side effect of the Error() or Errors() function?

@thedevsaddam thedevsaddam added the bug Something isn't working label Mar 27, 2020
@thedevsaddam thedevsaddam self-assigned this Mar 27, 2020
thedevsaddam added a commit that referenced this issue Mar 27, 2020
thedevsaddam added a commit that referenced this issue Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants