Allow users to disable registrations #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
force-pushed
the
allow-registration-disabling
branch
from
7f59e68 to
b3c2c94
Compare
tnylea
reviewed
Nov 18, 2024
| <span class="opacity-[47%]"> {{ config('devdojo.auth.language.login.dont_have_an_account') }} </span> | ||
| <x-auth::elements.text-link data-auth="register-link" href="{{ route('auth.register') }}">{{ config('devdojo.auth.language.login.sign_up') }}</x-auth::elements.text-link> | ||
| </div> | ||
| @if(config('devdojo.auth.settings.registration_enabled')) |
There was a problem hiding this comment.
We may want to add a default value of true in this config, like so:
@if(config('devdojo.auth.settings.registration_enabled', true))There was a problem hiding this comment.
Good point, just updated that!
|
Thanks for adding the test to these. Would this also prevent people from registering using Social Auth like Google or Github? |
I've just extended the PR to include that as well! So now this includes:
|
|
Thanks dude! This looks great. I've added a few more options and configs. Now, you can center align the text. I've also removed the
|
tnylea
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per a few user requests on the DevDojo site:
Implementing that functionality. When disabled if someone visits the register route they will be redirected to the
/loginroute and see the following message: