Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Facebook image sharing height and width. #109

Merged
merged 2 commits into from
Oct 28, 2017

Conversation

bmcfetty
Copy link
Contributor

Providing these options ensures that the share image is immediately rendered in preview every time, without it the first time there will be no image preview until Facebook has crawled the site once - particularly useful if you have generated share images.

Providing these options ensures that the share image is immediately rendered in preview every time, without it the first time there will be no image preview until Facebook has crawled the site once.
Copy link
Owner

@thedaviddias thedaviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FlightOfGrey! Thanks for the addition! I was not aware about that, really good point.

But I think it's better if it's considered like a simple comment above Facebook Open Graph and not a checkbox item. What do you think?

@bmcfetty
Copy link
Contributor Author

Up to you, I wasn't sure of the best way to add it you're welcome to change it to whatever you think fits best.

@thedaviddias
Copy link
Owner

@FlightOfGrey, can you check my changes and tell me if it's good for you?

@MrSunshyne
Copy link
Collaborator

@FlightOfGrey wow that's a nice trick i can use today! thanks for sharing.

@thedaviddias thedaviddias merged commit 8eab7c0 into thedaviddias:master Oct 28, 2017
qirh pushed a commit to qirh/Front-End-Checklist-AR that referenced this pull request Dec 5, 2017
Adding Facebook image sharing height and width.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants