fix: support @types/picomatch v4
#156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/picomatchv4 makesMatcherhave an optional second argument. if set totrue, it makes the function return some object and not a string. This breaksfdir's types. To fix this, I replaced it with the already usedGlobMatchertype that's identical toMatcherexcept it doesn't require a second argument (this makes sense to use since, if the second argument was used, fdir would break at runtime since it doesn't expect an object)Ideally #147 should be merged first to avoid causing merge conflicts on that pr 🙏
For prior work see SuperchupuDev/tinyglobby@f2419f8
Also makes
picomatchimporting have modern syntax. It doesn't break any compatibility, everything changed works starting from node 10. And fdir supports node 12 and up (manually checked)