Add safe wrapper for getimagesizefromstring#728
Open
spawnia wants to merge 2 commits intothecodingmachine:masterfrom
Open
Add safe wrapper for getimagesizefromstring#728spawnia wants to merge 2 commits intothecodingmachine:masterfrom
spawnia wants to merge 2 commits intothecodingmachine:masterfrom
Conversation
The PHP documentation for getimagesizefromstring only says "See getimagesize" for return values, so the generator cannot detect that it returns false on failure. Added as a special case.
- Use array<mixed> for $image_info parameter value type - Mark channels and bits as optional in return type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP documentation for
getimagesizefromstringonly says "Seegetimagesize" in its return values section, so the generator's regex patterns cannot detect that it returnsfalseon failure. Added as a special case inlib/special_cases.php.The function is identical to
getimagesize(which is already wrapped) except it accepts image data as a string instead of a filename.