Skip to content

Conversation

@jderusse
Copy link
Contributor

@jderusse jderusse commented Nov 9, 2018

The method array_combine returns false when the 2 parameters don't have the same size (https://3v4l.org/GOeqM).

Documentaiton to the method: http://php.net/manual/fr/function.array-combine.php

@coveralls
Copy link

coveralls commented Nov 9, 2018

Pull Request Test Coverage Report for Build 123

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 30.539%

Files with Coverage Reduction New Missed Lines %
src/DocPage.php 4 89.33%
Totals Coverage Status
Change from base Build 121: 0.08%
Covered Lines: 153
Relevant Lines: 501

💛 - Coveralls

@roukmoute
Copy link

Do not forget to add it in https://github.com/thecodingmachine/phpstan-strict-rules

@jderusse
Copy link
Contributor Author

Hi @roukmoute,

Could you, please, provide hints about the integration of such changes in phpstan-strict-rules ?
May you update the CONTRIBUTING.md file to help contributors?

AFAIK, the integration of new function is automatically loaded in phpstan-safe-rule here https://github.com/thecodingmachine/phpstan-safe-rule/blob/master/src/Utils/FunctionListLoader.php#L21

@moufmouf
Copy link
Member

Hi @jderusse ,

Thanks a lot!

Absolutely nothing to say, this PR is perfect. 💯

@roukmoute , Jérémy is right, when a function is added to "Safe", there is no need to make a PR on PHPStan-safe-rule as PHPStan-safe-rule takes the list of functions from safe/generated/functionsList.php.

Let's merge this right now!

@moufmouf moufmouf merged commit 4547d46 into thecodingmachine:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants