Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing already existing exception detection #42

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Fixing already existing exception detection #42

merged 1 commit into from
Sep 18, 2018

Conversation

moufmouf
Copy link
Member

When an exception already exists in lib/Exceptions, it should not be generated in generated/Exceptions.

Closes #41

@coveralls
Copy link

coveralls commented Sep 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 90

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 29.35%
Files with Coverage Reduction New Missed Lines %
src/FileCreator.php 27 0.0%
Totals Coverage Status
Change from base Build 89: 0.0%
Covered Lines: 140
Relevant Lines: 477
💛 - Coveralls

@moufmouf moufmouf merged commit b5446e5 into thecodingmachine:master Sep 18, 2018
@moufmouf moufmouf deleted the dont_generate_coded_exceptions branch September 18, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moufmouf @coveralls