Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing json_decode error handling in README #36

Merged
merged 3 commits into from
Sep 14, 2018
Merged

Fixing json_decode error handling in README #36

merged 3 commits into from
Sep 14, 2018

Conversation

moufmouf
Copy link
Member

@moufmouf moufmouf commented Sep 14, 2018 •
edited
Loading

As noticed in #35, the sample error handling in the README with incorrect.
This PR fixes the example.

Closes #35

@coveralls
Copy link

coveralls commented Sep 14, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 80

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.503%
Totals Coverage Status
Change from base Build 76: 0.0%
Covered Lines: 119
Relevant Lines: 449
💛 - Coveralls

@moufmouf moufmouf merged commit 98b773f into thecodingmachine:master Sep 14, 2018
@linaori
Copy link

linaori commented Sep 14, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON example does not appear to be correct
3 participants
@moufmouf @coveralls @linaori