Skip to content

Undeclared "by reference" arguments are ignored #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moufmouf merged 2 commits into from
Sep 14, 2018
Merged

Undeclared "by reference" arguments are ignored #27

moufmouf merged 2 commits into from
Sep 14, 2018

Conversation

@moufmouf
Copy link
Member

@moufmouf moufmouf commented Sep 14, 2018

See #26 for details

The first commit adds a failing test

@coveralls
Copy link

coveralls commented Sep 14, 2018

Pull Request Test Coverage Report for Build 57

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.351%
Totals Coverage Status
Change from base Build 54: 0.0%
Covered Lines: 117
Relevant Lines: 444
💛 - Coveralls

@moufmouf moufmouf mentioned this pull request Sep 14, 2018
Merged
@moufmouf
Copy link
Member Author

moufmouf commented Sep 14, 2018

On build failes on a timeout solved by #28. Merging.

@moufmouf moufmouf merged commit 580dbf3 into thecodingmachine:master Sep 14, 2018
@moufmouf moufmouf deleted the default_by_ref branch September 14, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moufmouf @coveralls