Enhancement: Add support for rector/rector:~0.6.0 #176

localheinz · 2020-01-03T09:36:14Z

This PR

adds support for rector/rector:~0.6.0

Fixes #167.

generated/misc.php

Kharhamel · 2020-01-07T13:34:49Z

conflicts again. please remove the commit where you regenerate the file.

localheinz · 2020-01-07T13:39:23Z

@Kharhamel

Rebased!

Kharhamel · 2020-01-07T14:00:29Z

rector-migrate.yml

-    zip_entry_open: 'Safe\zip_entry_open'
-    zip_entry_read: 'Safe\zip_entry_read'
-    zlib_decode: 'Safe\zlib_decode'
+    $oldFunctionToNewFunction


isn't it a typo?

It looks like this line is making the pipeline fail

localheinz · 2020-01-07T15:15:26Z

.travis.yml

@@ -61,7 +61,9 @@ script:
    echo "Generated files are different from commited files. Please run './safe.php generate' command and commit the results."
    exit 1;
  fi
+- cd generator/tests/rector/default && composer install && composer rector && composer test && cd ../../../..


This ensures that using rector-migrate.yml is still possible.

localheinz · 2020-01-07T15:32:58Z

@Kharhamel

This works fine now, do you want to take another look?

Kharhamel · 2020-01-07T15:52:01Z

I don't know much about rector. If I understand correctly, we allow rector 0.6 support while still keeping the compatibility with 0.5? If so, i will merge it.

localheinz · 2020-01-07T16:14:49Z

@Kharhamel

Yes, that's it.

Since 1.0.0 has been tagged, the previous change would be breaking.

This way, users of rector/rector:~0.5.0 and rector/rector:~0.6.0 can both use the YAML configuration files.

Aerendir · 2020-01-07T18:48:28Z

If of any help, this works for me using Rector v0.6.

localheinz · 2020-01-07T22:24:29Z

Perhaps @TomasVotruba can have a quick look and confirm?

TomasVotruba · 2020-01-07T22:31:22Z

Better go with 0.6.7. There've been some changes

TomasVotruba · 2020-01-07T22:32:18Z

README.md

+$ composer require --dev rector/rector:~0.5
+```
+
+to install `rector/rector:~0.5`.


This part can be dropped, as very obsolete version. It also conflicts with PHPStan 0.11-, so extra troubles for no gain

👍

My take on this: we can keep support for rector:0.5 (in order to not break compatibility with users using old Rector) but we should definitely stop advertising this possibility in the README (the README should only contain information about the latest minor version)

TomasVotruba · 2020-01-07T22:32:45Z

README.md


 ```bash
-vendor/bin/rector process src/ --config vendor/thecodingmachine/safe/rector-migrate.yml
+$ vendor/bin/rector process src/ --config vendor/thecodingmachine/safe/rector-migrate-0.6.yml


Better support just one minor Rector version, this is rather confusing even to me

TomasVotruba · 2020-01-07T22:33:20Z

generator/tests/rector/0.6/composer.json

+  },
+  "require": {
+    "php": ">=7.1",
+    "rector/rector": "^0.6"


Rector 0.6 require PHP 7.2, so it can be bumped as well to be real

Updating the minimum PHP version is a BC. This requires a new major version of the entire library...

This a test file.

And bumping PHP version is not a BC break, as it only narrows scope.

Aerendir · 2020-01-07T22:46:15Z

I'm an happy user of both Rector and Safe.

Reading your comments, one strange idea came to my mind: what if the support for Safe is provided directly by Rector?

This way, Safe remain an independent very useful package that doesn't break each time Rector is updated...

As told, this is a strange idea 😅

TomasVotruba · 2020-01-07T22:47:05Z

Reading your comments, one strange idea came to my mind: what if the support for Safe is provided directly by Rector?

Well you're right, that's what 99 % projects do :D so feel free to send PR there!

EDIT: Think of it as Symfony Flex with just with upgrade recipes

localheinz · 2020-01-08T08:46:51Z

Thank you for your feedback, @TomasVotruba - I made a few adjustments here!

localheinz · 2020-01-08T09:08:14Z

Thank you, @Aerendir, @Kharhamel, @moufmoufm and @TomasVotruba!

Aerendir · 2020-01-08T15:25:12Z

Reading your comments, one strange idea came to my mind: what if the support for Safe is provided directly by Rector?

Well you're right, that's what 99 % projects do :D so feel free to send PR there!

EDIT: Think of it as Symfony Flex with just with upgrade recipes

I don't understand... Where should have I to submit the PR? I'm not the owner nor I'm involved in the Safe library: I have no decision power about it...

What should have I to do?

TomasVotruba · 2020-01-08T16:42:06Z

The example would the best. If something in Symfony 3.3 changes, it should be added here:
https://github.com/rectorphp/rector/blob/master/config/set/symfony/symfony33.yaml

For this package and version, it would be:

https://github.com/rectorphp/rector/blob/master/config/set/thecodingmachine/safe10.yaml

Aerendir · 2020-01-09T16:40:00Z

@TomasVotruba , ok, now it is clear: so, it sufficient to copy the current file rector-migrate*.yml from Safe to https://github.com/rectorphp/rector/blob/master/config/set/thecodingmachine/safe10.yaml?

@localheinz , WDYT about this? Can I submit the PR to Rector: have I your permission?

TomasVotruba · 2020-01-09T16:53:33Z

@TomasVotruba , ok, now it is clear: so, it sufficient to copy the current file rector-migrate*.yml from Safe to https://github.com/rectorphp/rector/blob/master/config/set/thecodingmachine/safe10.yaml?

👍

Aerendir · 2020-01-19T01:55:26Z

Ping

localheinz · 2020-01-19T08:37:06Z

@Aerendir

Perhaps we can find a way to automatically open a pull request whenever we have any changes in the corresponding YAML file?

Maybe using https://github.com/gr2m/create-or-update-pull-request-action?

TomasVotruba · 2020-03-27T15:53:59Z

There you go: rectorphp/rector#3078

You can update the set path:

-vendor/bin/rector process src --config vendor/thecodingmachine/safe/rector-migrate-0.7.yml
+vendor/bin/rector process src --config vendor/rector/rector/config/set/thecodingmachine/safe07.yaml

localheinz commented Jan 3, 2020

View reviewed changes

generated/misc.php Outdated Show resolved Hide resolved

localheinz force-pushed the feature/rector branch from 975fa2e to 3d226da Compare January 3, 2020 10:23

localheinz mentioned this pull request Jan 3, 2020

Fix: Regenerate files #178

Merged

1 task

Kharhamel mentioned this pull request Jan 7, 2020

Missing support for rector 0.6 #157

Closed

localheinz force-pushed the feature/rector branch from a075ef2 to c2438c9 Compare January 7, 2020 13:38

Kharhamel reviewed Jan 7, 2020

View reviewed changes

localheinz force-pushed the feature/rector branch from b970293 to 4402f5d Compare January 7, 2020 14:49

localheinz changed the title ~~Enhancement: Use rector/rector:^0.6~~ Enhancement: Add support for rector/rector:~0.6.0 Jan 7, 2020

localheinz force-pushed the feature/rector branch 7 times, most recently from f0fe776 to 3d96207 Compare January 7, 2020 15:11

localheinz commented Jan 7, 2020

View reviewed changes

TomasVotruba reviewed Jan 7, 2020

View reviewed changes

localheinz force-pushed the feature/rector branch 3 times, most recently from cb776ed to 0911c2a Compare January 8, 2020 08:46

Enhancement: Add support for rector/rector:~0.6.0

66c9cc2

localheinz force-pushed the feature/rector branch from 0911c2a to 66c9cc2 Compare January 8, 2020 08:46

Kharhamel merged commit 9acc5ae into thecodingmachine:master Jan 8, 2020

localheinz deleted the feature/rector branch January 8, 2020 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement: Add support for rector/rector:~0.6.0 #176

Enhancement: Add support for rector/rector:~0.6.0 #176

localheinz commented Jan 3, 2020 •

edited

Loading

Kharhamel commented Jan 7, 2020

localheinz commented Jan 7, 2020

Kharhamel Jan 7, 2020

Kharhamel Jan 7, 2020 •

edited

Loading

localheinz Jan 7, 2020

localheinz commented Jan 7, 2020

Kharhamel commented Jan 7, 2020

localheinz commented Jan 7, 2020

Aerendir commented Jan 7, 2020

localheinz commented Jan 7, 2020

TomasVotruba commented Jan 7, 2020

TomasVotruba Jan 7, 2020

moufmouf Jan 8, 2020

TomasVotruba Jan 7, 2020

TomasVotruba Jan 7, 2020

Aerendir Jan 7, 2020

TomasVotruba Jan 7, 2020

Aerendir commented Jan 7, 2020

TomasVotruba commented Jan 7, 2020 •

edited

Loading

localheinz commented Jan 8, 2020

localheinz commented Jan 8, 2020

Aerendir commented Jan 8, 2020

TomasVotruba commented Jan 8, 2020 •

edited

Loading

Aerendir commented Jan 9, 2020

TomasVotruba commented Jan 9, 2020

Aerendir commented Jan 19, 2020

localheinz commented Jan 19, 2020

TomasVotruba commented Mar 27, 2020

Enhancement: Add support for rector/rector:~0.6.0 #176

Enhancement: Add support for rector/rector:~0.6.0 #176

Conversation

localheinz commented Jan 3, 2020 • edited Loading

Kharhamel commented Jan 7, 2020

localheinz commented Jan 7, 2020

Choose a reason for hiding this comment

Kharhamel Jan 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

localheinz commented Jan 7, 2020

Kharhamel commented Jan 7, 2020

localheinz commented Jan 7, 2020

Aerendir commented Jan 7, 2020

localheinz commented Jan 7, 2020

TomasVotruba commented Jan 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aerendir commented Jan 7, 2020

TomasVotruba commented Jan 7, 2020 • edited Loading

localheinz commented Jan 8, 2020

localheinz commented Jan 8, 2020

Aerendir commented Jan 8, 2020

TomasVotruba commented Jan 8, 2020 • edited Loading

Aerendir commented Jan 9, 2020

TomasVotruba commented Jan 9, 2020

Aerendir commented Jan 19, 2020

localheinz commented Jan 19, 2020

TomasVotruba commented Mar 27, 2020

localheinz commented Jan 3, 2020 •

edited

Loading

Kharhamel Jan 7, 2020 •

edited

Loading

TomasVotruba commented Jan 7, 2020 •

edited

Loading

TomasVotruba commented Jan 8, 2020 •

edited

Loading