Skip to content

Fix MagicField & SourceField to include $annotations parameter #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oprypkhantc
Copy link
Contributor

Closes #563

@oprypkhantc
Copy link
Contributor Author

oprypkhantc commented Mar 2, 2023

PHPStan is failing but it seems like the problem is because phpstan is not locked to a patch/minor version in composer.json. Same goes doctrine/coding-standard locally by the way - it spits out a couple of errors completely unrelated to my changes.

Maybe just lock those two to a specific minior version? phpstan: "~1.9.0" and doctrine/coding-standard: "~11.0.0"

@oojacoboo
Copy link
Collaborator

These errors should be resolved on master now. I pushed commits that fixed them yesterday. I'm not sure why they're failing again here.

@oojacoboo oojacoboo merged commit 6991df9 into thecodingmachine:master Mar 8, 2023
@oprypkhantc
Copy link
Contributor Author

I was just in the process of merging master into this branch to fix the phpstan :) Thanks!

@oprypkhantc oprypkhantc deleted the add-annotations-parameters branch March 8, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing annotations parameter in #[MagicField] and #[SourceField]
2 participants