Skip to content

- fixes bug in CompilerPass #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

faizanakram99
Copy link
Contributor

  • fixes tests

@nguyenk
Copy link
Member

nguyenk commented Aug 29, 2023

Hello @faizanakram99 almost done, we're missing PHPStan, I'm OK with a simple ignore next line
We could also completely remove doctine/annotations 1, but I think this might break sometimes in old installs or graphqlite

@faizanakram99
Copy link
Contributor Author

faizanakram99 commented Aug 29, 2023

Hello @faizanakram99 almost done, we're missing PHPStan, I'm OK with a simple ignore next line We could also completely remove doctine/annotations 1, but I think this might break sometimes in old installs or graphqlite

thanks, fixed.

Do you want me to squash commits?

@nguyenk nguyenk merged commit 54959bd into thecodingmachine:master Aug 29, 2023
@nguyenk
Copy link
Member

nguyenk commented Aug 29, 2023

Thank you I did it ! Credits to @faizanakram99 and @aszenz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants