Skip to content

SF 6 support #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 25, 2023
Merged

SF 6 support #166

merged 14 commits into from
Jun 25, 2023

Conversation

nguyenk
Copy link
Member

@nguyenk nguyenk commented Mar 20, 2023

No description provided.

Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
@aszenz
Copy link
Contributor

aszenz commented Jun 21, 2023

@nguyenk Any way i could help in moving this pr forward

@nguyenk
Copy link
Member Author

nguyenk commented Jun 21, 2023

Hello @aszenz, please check comment here #142 (comment)

I released the beta 6.0 but still no feedback. Did you test it? If it's working then I think we can merge it!

@aszenz
Copy link
Contributor

aszenz commented Jun 21, 2023

I released the beta 6.0 but still no feedback. Did you test it? If it's working then I think we can merge it!

Thanks, that's great

I just upgraded the pkg in our app, we were already using symfony 6.2 using a forked pkg.

I had to change the minimum stability to dev for it to work
This is what composer did:

  - Upgrading thecodingmachine/graphqlite (v5.0.3 => v6.0.0)
  - Upgrading thecodingmachine/graphqlite-bundle (v5.4.0 => 6.0.x-dev e567930)
  - Upgrading thecodingmachine/graphqlite-symfony-validator-bridge (dev-jerowork/upgrade-symfony-to-6 fb5515e => 6.0.x-dev 7b1ee6e)

Our ci pipeline succeeded and I tested few screens manually which use graphql, everything seems to work fine.

I guess we need to release a new version for both graphqlite-bundle and graphqlite-symfony-validator-bridge pkgs

I do see some deprecations on symfony 6 though for this pkg, I guess we could fix them after release as well.

  • Method "Overblog\GraphiQLBundle\Config\GraphiQLControllerEndpoint::getBySchema()" might add "string" as a native return type declaration in the future. Do the same in implementation "TheCodingMachine\GraphQLite\Bundle\GraphiQL\EndpointResolver" now to avoid errors or add an explicit @return annotation to suppress this message.
  • Method "Overblog\GraphiQLBundle\Config\GraphiQLControllerEndpoint::getDefault()" might add "string" as a native return type declaration in the future. Do the same in implementation "TheCodingMachine\GraphQLite\Bundle\GraphiQL\EndpointResolver" now to avoid errors or add an explicit @return annotation to suppress this message.
  • Since symfony/console 6.1: Relying on the static property "$defaultName" for setting a command name is deprecated. Add the "Symfony\Component\Console\Attribute\AsCommand" attribute to the "TheCodingMachine\GraphQLite\Bundle\Command\DumpSchemaCommand" class instead.
  • User Deprecated: Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "GraphQL\Language\AST\NodeList" now to avoid errors or add an explicit @return annotation to suppress this message.
  • Deprecated: Using ${var} in strings is deprecated, use {$var} instead

@aszenz
Copy link
Contributor

aszenz commented Jun 22, 2023

@nguyenk Created #174 to fix the deprecation's, we can merge it in this pr

aszenz and others added 6 commits June 24, 2023 07:12
+ Fix MyException to use GraphQLInterface
Pass enabled argument to service
extensions automatically now
for latest webonyx graphql pkg

+ Use built in sort types option
+ Fix for subscription error
chore: Fix deprecations and tests for symfony 6, graphqlite 6 and php8.1
@nguyenk nguyenk changed the title Draft : change to Symfony 6 SF 6 support Jun 25, 2023
@nguyenk nguyenk merged commit 947d4ae into master Jun 25, 2023
@nguyenk
Copy link
Member Author

nguyenk commented Jun 25, 2023

@aszenz merged to master, thank you again for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants