Skip to content

Add types + Improve bundle output #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

qurafi
Copy link

@qurafi qurafi commented Apr 22, 2022

This pull request adds types for this component. In addition, I noticed the bundle output is invalid and the CSS output is missing. It has no effect on sveltekit or Rollup because they use the "svelte" field directly from package.json. but if it used standalone, it will be broken. I fixed that and removed the index.svelte file because Rollup will treat it as Svelte component and will compile it in the bundle.

@thecodejack
Copy link
Owner

Thank you for the PR. I am looking into this change and will merge it if all is good.

@thecodejack
Copy link
Owner

@mhmd-22 looks like docs build is failing after change. Can you also fix same before I further check changes?

@thecodejack
Copy link
Owner

Also if possible can you avoid spacing changes for now. We can have a special commit if required. Finding it hard what changes happened.

@qurafi
Copy link
Author

qurafi commented May 3, 2022

I checked the build logs. looks like a node version mismatch between some dependencies. I will suggest rebuild this project with Sveltekit instead. it has all the tooling we need(typescript out of the box + library packaging). I will suggest also if we move docs from Netlify to Github pages it al lot easier in my opinion.

For spacing changes. Sorry. that my editor doing it automatically. You could provide .prettierrc to avoid this issues

@thecodejack thecodejack mentioned this pull request Aug 7, 2022
@mathewcst
Copy link

Hey guys, any updates on this? Would love to have TS support

@arackaf
Copy link
Collaborator

arackaf commented Mar 11, 2023

@mathewcst I've got a PR up to move this project up to svelte-package (ie SvelteKit), linked in the PR is a deployment from my own fork which you can use until mine is merged and deployed

#127

@arackaf
Copy link
Collaborator

arackaf commented Apr 6, 2024

Closing this - library should now be built by svelte-package so I'm not sure this is needed. If I'm wrong, feel free to resurrect this and handle the conflicts

@arackaf arackaf closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants