Fixed HTTP Header 'host' parameter parsing #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecatalinstan
approved these changes
Feb 13, 2021
| @@ -136,6 +136,10 @@ - (void)socket:(GCDAsyncSocket *)sock didReadData:(NSData*)data withTag:(long)ta | |||
| CRHTTPVersion version = CRHTTPVersionMake(versionSpec); | |||
|
|
|||
| NSRange rangeOfHostHeader = [data rangeOfData:[@"Host: " dataUsingEncoding:NSUTF8StringEncoding] options:0 range:NSMakeRange(0, data.length)]; | |||
|
|
|||
| // Since HTTP header fields are case-insensitive (https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2), we have to check for both `Host` and `host`. | |||
There was a problem hiding this comment.
This will solve that case, but what if somebody decides to go with more creative approaches. HosT, aso. We should compare it lowercased. But that is for the future. This should solve immediate issues
There was a problem hiding this comment.
What about converting data to a string, setting it all to lowercase, and then checking for host: against that? Do you think that would be a better long-term solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since HTTP header fields are case-insensitive (see here), we have to check for both
Hostandhostfor the http host header. This checks for the existence ofhost:ifHost:returns nothing.