Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android, sdk12)!: update to facebook-android-sdk 12 #127

Merged
merged 11 commits into from
Nov 11, 2021

Commits on Nov 9, 2021

  1. build(release): use yarn for release

    yarn was used everywhere else, and using `npm ci` required inclusion
    of a package-lock.json which could have different dependencies than yarn.lock
    
    this allows the use of one single yarn.lock, but the --frozen-lockfile argument
    on yarn install in combination with purging node_modules emulates `npm ci`
    behavior
    mikehardy committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    3635db4 View commit details
    Browse the repository at this point in the history
  2. build(release): use semantic-release from node_modules/.bin every time

    this way we are in control of the version, npx may pull something in over
    the network, which is unwanted in CI / release where we need total control
    mikehardy committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    0166ca0 View commit details
    Browse the repository at this point in the history
  3. build(ci): bump versions of all items in workflows

    also improve caching of yarn items by adding a version key, in case
    we need to forcibly remove caches in future
    mikehardy committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    b325adf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0caa86a View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. docs(example): improve contribution / development docs, update refres…

    …h-example.sh
    
    This includes all the current configuration items noted in app startup logs / native
    integration guides
    
    this improves the developer experience, all things noted or needed while
    I was working with the example to update the android SDK
    mikehardy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    639535d View commit details
    Browse the repository at this point in the history
  2. fix(app-events)!: remove updateUserProperties method

    BREAKING CHANGE: upstream SDKs removed updateUserProperties, there is no replacement
    mikehardy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    dc158c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    47f9770 View commit details
    Browse the repository at this point in the history
  4. chore(example): result of running refresh-example.sh after updates

    this proves Android targetSdk 31 works, when combined with facebook-android-sdk v12
    mikehardy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    4ceac39 View commit details
    Browse the repository at this point in the history
  5. build(deps): bump all dependencies, disable flow type checking

    note that we are not compatible with the new flow types, they get stricter
    every time. maintenance effort will be spent on typescript, with apologies
    
    feel free to post a PR that brings flow types up to v158 and re-enables
    the check in the CI test workflow
    mikehardy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    e8767cf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3e44228 View commit details
    Browse the repository at this point in the history
  7. test(ci): build against dev code / fix arch issue

    this will fix the build in CI for iOS at the same time it ensures
    we run CI against the actual development code (vs github master, which
    is what yarn installs by default)
    
    pod install will fail on ubuntu (when building android) so allow it to fail
    with the `|| true` bit, but we still install the dev code dependencies so
    android tests actual dev code
    mikehardy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    a9506bd View commit details
    Browse the repository at this point in the history